Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX-3465] feat: update uwb #361

Merged
merged 8 commits into from
Dec 2, 2024
Merged

[DX-3465] feat: update uwb #361

merged 8 commits into from
Dec 2, 2024

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Nov 28, 2024 •
edited
Loading

Summary

Passport package

  • Update UnityWebBrowser (UWB). Everything in src/Packages/Passport/Runtime/ThirdParty/UnityWebBrowser is straight from UWB v2.2.5 version. Only two changes have been made:
    • Added the ability to turn off sandbox.
    • Skip the PixelDataLoop so it can be headless.
  • Updated game bridge file to include new callback function for UWB.

Sample app

  • Added a launch browser scene to showcase how to use UWB to load a web page.

Tests

  • Updated test account
  • I commented out the register off-chain UI test case for now as the Passport throws a server error.

Other things to consider:

  • Sample app is updated with new SDK changes

@nattb8 nattb8 requested a review from a team as a code owner November 28, 2024 05:33
@nattb8 nattb8 changed the title feat: update uwb [DX-3465] feat: update uwb Dec 2, 2024
@nattb8 nattb8 merged commit baa863c into main Dec 2, 2024
23 of 25 checks passed
@nattb8 nattb8 deleted the feat/windows-uwb branch December 2, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImmutableJeffrey ImmutableJeffrey ImmutableJeffrey approved these changes

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattb8 @ImmutableJeffrey