Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX-3465] fix: windows webview assembly file and sample app webview #367

Merged
merged 1 commit into from
Dec 8, 2024
Merged

[DX-3465] fix: windows webview assembly file and sample app webview #367

merged 1 commit into from
Dec 8, 2024
+264 −96

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Dec 8, 2024

Summary

  • Fixed assembly definition file
  • I added an open dev tools button to the sample for the Windows launch browser scene.

Other things to consider:

  • Sample app is updated with new SDK changes

@nattb8 nattb8 requested a review from a team as a code owner December 8, 2024 22:16
@nattb8 nattb8 force-pushed the fix/windows-webview-sample branch from 022d4b7 to ffb3b3b Compare December 8, 2024 23:16
@nattb8 nattb8 force-pushed the fix/windows-webview-sample branch from ffb3b3b to f1f514a Compare December 8, 2024 23:38
@ImmutableJeffrey ImmutableJeffrey self-requested a review December 8, 2024 23:57
@nattb8 nattb8 merged commit da1e4ed into main Dec 8, 2024
18 checks passed
@nattb8 nattb8 deleted the fix/windows-webview-sample branch December 8, 2024 23:59
@github-actions github-actions bot added the fix label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImmutableJeffrey ImmutableJeffrey ImmutableJeffrey approved these changes

Assignees
No one assigned
Labels
fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattb8 @ImmutableJeffrey