Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused imports, nullables, update readmes #369

Merged
merged 1 commit into from
Dec 17, 2024
Merged

refactor: remove unused imports, nullables, update readmes #369

merged 1 commit into from
Dec 17, 2024
+83 −176

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Dec 17, 2024 •
edited
Loading

Summary

  • Updated the README for Passport and Marketplace packages
  • Removed unused imports
  • Simplified nullable values, marked private fields/arguments as nullable
  • Only call get logout URL if hardLogout is true
  • Don't compare the Passport package README with the Unity SDK README to ensure consistency, as we now have multiple packages.

@nattb8 nattb8 requested a review from a team as a code owner December 17, 2024 04:27
@nattb8 nattb8 merged commit f4d4bc3 into main Dec 17, 2024
18 checks passed
@nattb8 nattb8 deleted the refactor/nullable branch December 17, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImmutableJeffrey ImmutableJeffrey ImmutableJeffrey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattb8 @ImmutableJeffrey