Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX-2357] Send engine and platform info on Passport init #86

Merged
merged 5 commits into from
Sep 29, 2023
Merged

[DX-2357] Send engine and platform info on Passport init #86

merged 5 commits into from
Sep 29, 2023

Conversation

CodeSchwert
Copy link
Collaborator

@CodeSchwert CodeSchwert commented Sep 25, 2023 •
edited by jira bot
Loading

Summary

DX-2357

Send engine version and platform info from Passport init to game bridge.

@CodeSchwert CodeSchwert requested a review from nattb8 September 25, 2023 05:40
@CodeSchwert CodeSchwert force-pushed the DX-2357/unity-check-version branch from daa8e2a to 76b72b0 Compare September 26, 2023 04:57
@CodeSchwert CodeSchwert force-pushed the DX-2357/unity-check-version branch from 76b72b0 to af89001 Compare September 26, 2023 04:59
nattb8
nattb8 previously approved these changes Sep 26, 2023
View reviewed changes
nattb8
nattb8 reviewed Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@nattb8 nattb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update the index file in the repo?

@nattb8 nattb8 self-requested a review September 26, 2023 05:23
dom-murray
dom-murray previously approved these changes Sep 26, 2023
View reviewed changes
@CodeSchwert CodeSchwert dismissed stale reviews from dom-murray and nattb8 via 35f91a7 September 26, 2023 22:35
carleeto
carleeto previously approved these changes Sep 27, 2023
View reviewed changes
carleeto
carleeto previously approved these changes Sep 28, 2023
View reviewed changes
@CodeSchwert CodeSchwert force-pushed the DX-2357/unity-check-version branch from f85d538 to 49a5142 Compare September 28, 2023 05:33
@CodeSchwert CodeSchwert requested a review from nattb8 September 28, 2023 05:38
@CodeSchwert CodeSchwert merged commit ef8d840 into main Sep 29, 2023
5 checks passed
@dom-murray dom-murray deleted the DX-2357/unity-check-version branch October 9, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nattb8 nattb8 nattb8 approved these changes

@carleeto carleeto carleeto approved these changes

@dom-murray dom-murray Awaiting requested review from dom-murray

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CodeSchwert @carleeto @dom-murray @nattb8