feat: use ASWebAuthenticationSession for iOS PKCE #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CassiusPacheco
force-pushed
the
ios-sso
branch
2 times, most recently
from
2648059 to
ff12f74
Compare
nattb8
previously approved these changes
Oct 2, 2023
src/Packages/Passport/Runtime/Scripts/Private/Core/BrowserCommunicationsManager.cs
Outdated
Show resolved
Hide resolved
This is the standard way of dealing with SSO on iOS. Asynchronous error handling is now being bubbled up to PassportImpl where it can be parsed by their identifier to complete unfinished tasks.
These logs were making developers confused that errors where being thrown, when in reality most of the time that wasnt the case.
CassiusPacheco
force-pushed
the
ios-sso
branch
from
ff12f74 to
55287dc
Compare
nattb8
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the standard way of dealing with SSO on iOS.
Asynchronous error handling is now being bubbled up to PassportImpl
where it can be parsed by their identifier to complete unfinished
tasks.