refactor: android custom tabs to not use lambdas (#62)

immutable · Jan 25, 2024 · 2a71c8d · 2a71c8d
1 parent 9e5f4c7
commit 2a71c8d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 8 deletions.
diff --git a/Source/Immutable/Immutable_UPL_Android.xml b/Source/Immutable/Immutable_UPL_Android.xml
@@ -18,6 +18,16 @@
             -keep interface androidx.** { *; }
         </insert>
     </proguardAdditions>
+    <buildGradleAdditions>
+        <insert>
+            android {
+                compileOptions {
+                    sourceCompatibility 1.8
+                    targetCompatibility 1.8
+                }
+            }
+        </insert>
+    </buildGradleAdditions>
     <androidManifestUpdates>
         <addElements tag="queries">
             <intent>

diff --git a/Source/Immutable/Private/Immutable/Android/Java/CustomTabsController.java b/Source/Immutable/Private/Immutable/Android/Java/CustomTabsController.java
@@ -111,14 +111,17 @@ public void launch(@NonNull final Uri uri) {
             context.startActivity(new Intent(Intent.ACTION_VIEW, uri));
         } else {
             // Running in a different thread to prevent doing too much work on main thread
-            new Thread(() -> {
-                try {
-                    launchCustomTabs(context, uri);
-                } catch (ActivityNotFoundException ex) {
-                    // Failed to launch Custom Tab browser, so launch in browser
-                    context.startActivity(new Intent(Intent.ACTION_VIEW, uri));
-                }
-            }).start();
+            new Thread(new Runnable() {
+               @Override
+               public void run() {
+                   try {
+                       launchCustomTabs(context, uri);
+                   } catch (ActivityNotFoundException ex) {
+                       // Failed to launch Custom Tab browser, so launch in browser
+                       context.startActivity(new Intent(Intent.ACTION_VIEW, uri));
+                   }
+               }
+           }).start();
         }
     }