Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: android custom tabs to not use lambdas #62

Merged
merged 1 commit into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Source/Immutable/Immutable_UPL_Android.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@
-keep interface androidx.** { *; }
</insert>
</proguardAdditions>
<buildGradleAdditions>
<insert>
android {
compileOptions {
sourceCompatibility 1.8
targetCompatibility 1.8
}
}
</insert>
</buildGradleAdditions>
<androidManifestUpdates>
<addElements tag="queries">
<intent>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,17 @@ public void launch(@NonNull final Uri uri) {
context.startActivity(new Intent(Intent.ACTION_VIEW, uri));
} else {
// Running in a different thread to prevent doing too much work on main thread
new Thread(() -> {
try {
launchCustomTabs(context, uri);
} catch (ActivityNotFoundException ex) {
// Failed to launch Custom Tab browser, so launch in browser
context.startActivity(new Intent(Intent.ACTION_VIEW, uri));
}
}).start();
new Thread(new Runnable() {
@Override
public void run() {
try {
launchCustomTabs(context, uri);
} catch (ActivityNotFoundException ex) {
// Failed to launch Custom Tab browser, so launch in browser
context.startActivity(new Intent(Intent.ACTION_VIEW, uri));
}
}
}).start();
}
}

Expand Down
Loading