Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-2614] fix: sample blueprints missing functions, incorrect login/connect #64

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jan 28, 2024

Summary

Fixed sample blueprints and added more comments on what each section means.

ImtblUnauthenticatedLevel

  • There were no examples of how to log in and connect using a saved cache session. Added 'Relogin' and 'Reconnect' buttons.
  • The Login button was hooked to the Connect Imx node. Reconnected it to Login.
  • Prevented users from attempting to log in/connect before the Passport is ready by hiding buttons until initialisation is complete

ImtblAuthenticatedLevel

  • If the user is not connected (i.e. clicked on the 'Login' or 'Relogin' button on the unauthenticated level), IMX-related buttons should not be visible as there is no IMX provider. Without the IMX provider, none of the IMX buttons would work. Therefore, I added a 'Connect' button to allow users to connect later and instantiate an IMX provider.

Customer Impact

N/A

Other things to consider:

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • N/A Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • N/A Replied to GitHub issues

@nattb8 nattb8 requested a review from a team as a code owner January 28, 2024 22:22
@nattb8 nattb8 merged commit f8aae15 into main Feb 1, 2024
8 checks passed
@nattb8 nattb8 deleted the fix/sample-blueprints branch February 1, 2024 02:34
@github-actions github-actions bot added the fix label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants