Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-2604] fix: added error output message parameter for RegisterOffChain #66

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Feb 6, 2024

Summary

Modified delegate output for RegisterOffChain node. Separated hash value and error message.

Changed

Added new output value for RegisterOffChain blueprint node.

Other things to consider:

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • N/A Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • N/A Replied to GitHub issues

@YermekG YermekG requested a review from nattb8 February 6, 2024 22:22
@YermekG YermekG requested a review from a team as a code owner February 6, 2024 22:22
@YermekG YermekG changed the title [DX-2604] fix: added error output message parameter for RegisterOffCh… [DX-2604] fix: added error output message parameter for RegisterOffChain Feb 6, 2024
@YermekG YermekG force-pushed the fix/registeroffchain branch from f5ff70d to 65972fb Compare February 6, 2024 22:24
Copy link
Collaborator

@nattb8 nattb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the sample blueprint be updated for register off chain? From memory it doesn't handle error case, because the output pin does not exist.

@YermekG
Copy link
Contributor Author

YermekG commented Feb 6, 2024

Should the sample blueprint be updated for register off chain? From memory it doesn't handle error case, because the output pin does not exist.

Updated the sample blueprint

@YermekG YermekG force-pushed the fix/registeroffchain branch from 7acf799 to 69d3196 Compare February 6, 2024 22:38
@YermekG YermekG force-pushed the fix/registeroffchain branch from 69d3196 to 8140076 Compare February 6, 2024 22:40
@YermekG YermekG enabled auto-merge (squash) February 6, 2024 22:43
@YermekG YermekG merged commit 164135c into main Feb 6, 2024
8 checks passed
@github-actions github-actions bot added the fix label Feb 6, 2024
@nattb8 nattb8 deleted the fix/registeroffchain branch February 6, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants