Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-2616] fix: failed login with cached session falls back to login pkce #68

Closed
wants to merge 1 commit into from

Conversation

YermekG
Copy link
Contributor

@YermekG YermekG commented Feb 8, 2024

Summary

Session that was previously logged in with PKCE flow fall back to PKCE login flow in the event of a relogin failure. The same behaviour is expected for connect with PKCE flow

Customer Impact

Improves customer experience

Things worth calling out

Other things to consider:

  • Prefix your PR title with feat: , fix: , chore: , docs: , refactor: or test: .
  • Sample blueprints are updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Replied to GitHub issues

@YermekG YermekG requested a review from a team as a code owner February 8, 2024 03:46
@YermekG YermekG closed this Feb 8, 2024
@YermekG YermekG deleted the  fix/relogin_pkce branch February 8, 2024 03:49
@YermekG
Copy link
Contributor Author

YermekG commented Feb 8, 2024

I named branch incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant