[DX-2591] fix: adjusted blui process closure routines #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YermekG
changed the title
nattb8
reviewed
Feb 13, 2024
wdinau
reviewed
Feb 13, 2024
There was a problem hiding this comment.
There was a lot of format change (without business logic change). I can't immediately figure out what was the critical code fixed the performance.
Was the format change a mistake or because of you use proper linting? After this change, do we have consistent linting throughout the entire unreal sdk code?
chore: adjusted code style fix: stop blui event loop on exit chore: added blui macro condition Revert "chore: adjusted code style" This reverts commit 40973e8. # Conflicts: # Source/Immutable/Private/Immutable/ImmutableSubsystem.cpp
|
I removed the formating. |
nattb8
approved these changes
Feb 13, 2024
wdinau
reviewed
Feb 13, 2024
wdinau
reviewed
Feb 13, 2024
wdinau
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We added CEF message loop stop method before BLUI process closure. Also, we added a code that will forcefully close BLUI process if it still hangs.
Customer Impact
Improve memory performance on a game/app closure
Things worth calling out
Other things to consider:
feat:,fix:,chore:,docs:,refactor:ortest:.