Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-2589] feat: update game bridge to include mainnet configuration #72

Merged
merged 2 commits into from
Feb 20, 2024
Merged

[DX-2589] feat: update game bridge to include mainnet configuration #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf0a3e9
chore: updated bridge
YermekG Feb 20, 2024
cfc1df5
fix: add game thread execution on pkce dismiss to prevent crash on an…
YermekG Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Content/PackagedResources/index.uasset
View file
Open in desktop
Binary file not shown.
12 changes: 9 additions & 3 deletions Source/Immutable/Private/Immutable/ImmutablePassport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,11 +1090,17 @@ void UImmutablePassport::HandleOnLoginPKCEDismissed()
// User hasn't entered all required details (e.g. email address) into
// Passport yet
IMTBL_LOG("Login PKCE dismissed before completing the flow");
if (!PKCEResponseDelegate.ExecuteIfBound(FImmutablePassportResult{ false, "Cancelled" }))
if (FTaskGraphInterface::IsRunning())
{
IMTBL_WARN("Login PKCEResponseDelegate delegate was not called");
FGraphEventRef GameThreadTask = FFunctionGraphTask::CreateAndDispatchWhenReady([this]()
{
if (!PKCEResponseDelegate.ExecuteIfBound(FImmutablePassportResult{ false, "Cancelled" }))
{
IMTBL_WARN("Login PKCEResponseDelegate delegate was not called");
}
PKCEResponseDelegate = nullptr;
}, TStatId(), nullptr, ENamedThreads::GameThread);
}
PKCEResponseDelegate = nullptr;
}
else
{
Expand Down
Loading