-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMR-1834-WETH-Bridging #12
Conversation
address rootIMXToken = vm.envAddress("ROOT_IMX_ADDRESS"); | ||
address rootWETHToken = vm.envAddress("ROOT_WETH_ADDRESS"); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the steps into ./deploy.sh that deploy WETH (if local), and instructions in README for how to trigger this local deployment of WETH, and explaining that it needs to be manually set iff
./deploy.sh is not going to be run with the local flag
I've addressed the feedback here.
One thing i was thinking is we could just put the deposit call at the end of the _unwrapETH function and remove the need to call it then _deposit. We don't have a use case for only unwrapping yet and it's a private function, so currently its technically more modular than it needs to be. Not sure it's a big deal, happy to leave it how it is unless any major objections. |
the question i had above has been resolved and we decided to go with the option of combining the unwrapping and deposit steps into one function |
WETH bridging is now handled. WETH is unwrapped and send as ETH through the bridge.
Callouts
receive() external payable {}
method to root bridge so the WETH contract can send the ETH back which we unwrap.