Sprint 1 poc #14
Merged
Sprint 1 poc #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bridge tokens l1
…contracts into bridge-tokens-L2
Bridge tokens l2
…racts into deployment-scripts
…racts into SMR-1773-axelar-local
Smr 1773 axelar local
SMR-1834-WETH-Bridging
cleanup local axelar scripts for the Demo
ermyas
reviewed
Oct 31, 2023
| if (!Strings.equal(sourceAddress, rootERC20BridgeAdaptor)) { | ||
| revert InvalidSourceAddress(); | ||
| } | ||
| if (data.length == 0) { |
There was a problem hiding this comment.
Do we want to check if data.length > 32 here, so that we can throw a meaningful error in this case?
There was a problem hiding this comment.
Ticket added: https://immutable.atlassian.net/browse/SMR-1914
ermyas
reviewed
Oct 31, 2023
| _deposit(rootToken, receiver, amount); | ||
| // invariant check to ensure that the root token balance has increased by the amount deposited | ||
| // slither-disable-next-line incorrect-equality | ||
| if (rootToken.balanceOf(address(this)) != expectedBalance) { |
There was a problem hiding this comment.
There is a finding in the last ToB audit that this invariant check could fail for non-standard ERC20 tokens that take a percentage fee. Do we want to account for this? https://github.com/trailofbits/publications/blob/master/reviews/2023-08-immutable-securityreview.pdf
There was a problem hiding this comment.
Thanks for bringing that up. Discussion started in slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.