-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bootstrap Connection
aggregate
#131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
feat: bootstrap identity
feat: bootstrap Nov 26, 2024
Connection
aggregateConnection
aggregate
daniel-mader
approved these changes
Nov 28, 2024
🎉 This PR is included in version 1.0.0-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Added
A new feature that requires a minor release.
BREAKING CHANGE
A change to the API that requires a major release.
released on @beta
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There are two important changes in this PR:
Connection
aggregate inagent_verification
is merged into theAuthorizationRequest
aggregate.Connection
aggregate is added to theagent_identity
domain, this also means that two new endpoints are opened:/connections
bothGET
andPOST
: ForGET
additional query parameters can be added, for example:GET 'http://localhost:3033/v0/connections?did=did:example:123'
GET /connections/:connection_id
: To query a Connection byconnection_id
Note that in this PR the Connection aggregate is not that useful just yet. Once we have figured out a nice ergonomic way for different domains to 'interact' with each other, then connections can be created, or updated based on activity in the verification, issuance or holder domain.
Blocked by
Links to any relevant issues
How the change has been tested
Added unit tests and added Postman Collection Requests
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.