Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrap Connection aggregate #131

Merged
merged 92 commits into from
Nov 28, 2024
Merged

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Oct 5, 2024

Description of change

There are two important changes in this PR:

  1. The previous Connection aggregate in agent_verification is merged into the AuthorizationRequest aggregate.
  2. A new Connection aggregate is added to the agent_identity domain, this also means that two new endpoints are opened:
  • /connections both GET and POST: For GET additional query parameters can be added, for example: GET 'http://localhost:3033/v0/connections?did=did:example:123'
  • GET /connections/:connection_id: To query a Connection by connection_id

Note that in this PR the Connection aggregate is not that useful just yet. Once we have figured out a nice ergonomic way for different domains to 'interact' with each other, then connections can be created, or updated based on activity in the verification, issuance or holder domain.

Blocked by

Links to any relevant issues

How the change has been tested

Added unit tests and added Postman Collection Requests

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel changed the title feat: bootstrap identity Connection aggregate feat: bootstrap Connection aggregate Nov 26, 2024
Base automatically changed from nanderstabel/issue129 to beta November 26, 2024 10:13
@nanderstabel nanderstabel removed the Blocked Something blocks the integration of this code. label Nov 26, 2024
@nanderstabel nanderstabel merged commit 0d3a10d into beta Nov 28, 2024
2 checks passed
@nanderstabel nanderstabel deleted the nanderstabel/issue125 branch November 28, 2024 09:24
Copy link

🎉 This PR is included in version 1.0.0-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. BREAKING CHANGE A change to the API that requires a major release. released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants