Fix: PayPal onboarding with email address that has plus sign

[jonwaldstein]

Resolves GIVE-800

Description

The PayPal onboarding query params are not encoded, yet we are handling them as if they were encoded by parsing them. The problematic query param is the merchantId (email address) that could potentially have special character like a + sign. Ideally we would be able to encode that value before parsing it.

This PR does a really simple str_replace on plus signs to convert them to the encoded character.

Note: This has been reported to PayPal and they opened a ticket to investigate on there side. Their response was to handle the special characters on our end.

Affects

Paypal onboarding

Visuals

N/A

Testing Instructions

• connect to paypal using an email with a plus sign
• make sure that plus sign persists
• make sure donations go through as expected

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

[github-actions]

This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed.

[github-actions]

This PR is stale because it has been open 45 days with no activity. Stale PRs will NOT be automatically closed.