Add "touchY" plugin #753
Open
Add "touchY" plugin #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Arsenii and thanks for contributing It seems this is merely copying the functionality of the touch plugin. That doesn't seem like something I want to merge. Am I missing something? henrik |
|
henrik, you kinda right, this plugin adds support vertical swipes, and it is the slight modification of "touch" plugin that supports only horizontal swipes. So, the functionality of the original plugin "touch" and "touchY" the same, except directions of swipes. |
|
Why wouldn't you just add a configuration option to the existing plugin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a plugin that supports up/down swipes and touches to navigate. This is just a modification of the "touch" plugin.