[TASK] Use setter for domain property in some objects in a classic way

This helps if new objects should be created via extbase property mapper (e.g. via API) where a domain is given
in2code-de · Feb 1, 2024 · 3c58a86 · 3c58a86
1 parent 8ae77dc
commit 3c58a86
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 6 deletions.
diff --git a/Classes/Domain/Model/Download.php b/Classes/Domain/Model/Download.php
@@ -78,7 +78,13 @@ public function getDomain(): string
         return $this->domain;
     }
 
-    public function setDomain(): self
+    public function setDomain(string $domain): self
+    {
+        $this->domain = $domain;
+        return $this;
+    }
+
+    public function setDomainAutomatically(): self
     {
         $this->domain = FrontendUtility::getCurrentDomain();
         return $this;

diff --git a/Classes/Domain/Model/Newsvisit.php b/Classes/Domain/Model/Newsvisit.php
@@ -97,7 +97,13 @@ public function getDomain(): string
         return $this->domain;
     }
 
-    public function setDomain(): self
+    public function setDomain(string $domain): self
+    {
+        $this->domain = $domain;
+        return $this;
+    }
+
+    public function setDomainAutomatically(): self
     {
         $this->domain = FrontendUtility::getCurrentDomain();
         return $this;

diff --git a/Classes/Domain/Model/Pagevisit.php b/Classes/Domain/Model/Pagevisit.php
@@ -126,7 +126,13 @@ public function getDomain(): string
         return $this->domain;
     }
 
-    public function setDomain(): self
+    public function setDomain(string $domain): self
+    {
+        $this->domain = $domain;
+        return $this;
+    }
+
+    public function setDomainAutomatically(): self
     {
         $this->domain = FrontendUtility::getCurrentDomain();
         return $this;

diff --git a/Classes/Domain/Tracker/DownloadTracker.php b/Classes/Domain/Tracker/DownloadTracker.php
@@ -66,7 +66,8 @@ protected function getAndPersistNewDownload(string $href, int $pageIdentifier):
         $downloadRepository = GeneralUtility::makeInstance(DownloadRepository::class);
         $pageRepository = GeneralUtility::makeInstance(PageRepository::class);
         $page = $pageRepository->findByIdentifier($pageIdentifier);
-        $download = GeneralUtility::makeInstance(Download::class)->setHref($href)->setPage($page)->setDomain();
+        $download = GeneralUtility::makeInstance(Download::class)
+            ->setHref($href)->setPage($page)->setDomainAutomatically();
         if ($file !== null) {
             $download->setFile($file);
         }

diff --git a/Classes/Domain/Tracker/NewsTracker.php b/Classes/Domain/Tracker/NewsTracker.php
@@ -75,7 +75,7 @@ protected function getNewsvisit(
         $newsvisit
             ->setNews($news)
             ->setLanguage($languageUid)
-            ->setDomain()
+            ->setDomainAutomatically()
             ->setVisitor($visitor)
             ->setPagevisit($pagevisit);
         return $newsvisit;

diff --git a/Classes/Domain/Tracker/PageTracker.php b/Classes/Domain/Tracker/PageTracker.php
@@ -72,7 +72,7 @@ protected function getPageVisit(int $pageUid, int $languageUid, string $referrer
             ->setPage($page)
             ->setLanguage($languageUid)
             ->setReferrer($referrer)
-            ->setDomain()
+            ->setDomainAutomatically()
             ->setVisitor($visitor);
         return $pageVisit;
     }