Messages iobackends ultimo #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some tests we do a require of mosto.js, that in turn ends up calling iobackend.patchBackbone(). This wouldn't be a problem if it happens at the beginning but within the test suite models were created before and after that and it is not a very good thing (for instance, Backbone-relational crashes with a 'RangeError: Maximum call stack size exceeded'). So, we patch backbone before all tests are run and also move the require() statements inside the functions. That way they will be evaluated only when they are run and not when the whole test suite is built.
| _ = require('underscore') | ||
| ; | ||
|
|
||
| module.exports = function (db, test_db) { |
There was a problem hiding this comment.
I would use
function (db, test)
And if test is true, set the backends for test using db. Cant think of a case where db and testdb would be different dbs...
|
Can we have a test for this? Mosto is quite tested and it would be nice to keep it this way. Also, Travis is failing, could you check why? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also depends on inaes-tic/mbc-common#62
Previous discussion at #145