-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ruleset: erl_files_strict
#330
New ruleset: erl_files_strict
#330
Conversation
We simplify via list comprehensions We sort for readability Note: this brings no relevant code changes
@elbrujohalcon, I can't seem to add you as a reviewer, so ping'ing you this way. |
That's because you're @kivra-pauoli and not @paulo-ferraz-oliveira , Mr. Split-Personality-Dude 🤪 |
That much I know, but I thought anybody could add anybody as reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we have tests for these things, but this PR certainly has none :)
Nope. Only owners, admins, etc… |
It does have a test, that tests that all the relevant functions are called. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed it! Sorry. 🤦🏻
Feel free to generate a release with your other user if you think this is worth it, @kivra-pauoli :) |
Yeah, I hope to release soon. Not a big change, but one we could benefit from right away. It'll also potentially imply a release next to |
The goal of this ruleset, as discussed in #321, is to have all rules executing.
The first commit is just preparing the code for the feature.
The second commit is the feature implementation.
I implemented the tests in the simplest way possible, but it might hacky enough to warrant a comment to write them "better".
Closes #321.