Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ruleset: erl_files_strict #330

Merged
merged 2 commits into from
Jan 17, 2024
Merged

New ruleset: erl_files_strict #330

merged 2 commits into from
Jan 17, 2024

Conversation

kivra-pauoli
Copy link
Contributor

The goal of this ruleset, as discussed in #321, is to have all rules executing.

The first commit is just preparing the code for the feature.
The second commit is the feature implementation.

I implemented the tests in the simplest way possible, but it might hacky enough to warrant a comment to write them "better".

Closes #321.

We simplify via list comprehensions
We sort for readability

Note: this brings no relevant code changes
@kivra-pauoli
Copy link
Contributor Author

@elbrujohalcon, I can't seem to add you as a reviewer, so ping'ing you this way.

@elbrujohalcon
Copy link
Member

That's because you're @kivra-pauoli and not @paulo-ferraz-oliveira , Mr. Split-Personality-Dude 🤪

@kivra-pauoli
Copy link
Contributor Author

That much I know, but I thought anybody could add anybody as reviewers.

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have tests for these things, but this PR certainly has none :)

@elbrujohalcon
Copy link
Member

That much I know, but I thought anybody could add anybody as reviewers.

Nope. Only owners, admins, etc…

@kivra-pauoli
Copy link
Contributor Author

I'm not sure if we have tests for these things, but this PR certainly has none :)

It does have a test, that tests that all the relevant functions are called.

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed it! Sorry. 🤦🏻

@elbrujohalcon elbrujohalcon merged commit cb60dcd into inaka:main Jan 17, 2024
7 checks passed
@elbrujohalcon
Copy link
Member

Feel free to generate a release with your other user if you think this is worth it, @kivra-pauoli :)

@paulo-ferraz-oliveira
Copy link
Collaborator

Yeah, I hope to release soon. Not a big change, but one we could benefit from right away. It'll also potentially imply a release next to rebar3_lint.

@paulo-ferraz-oliveira
Copy link
Collaborator

3.2.0 is released on GitHub.
3.2.0 is released on Hex.

@kivra-pauoli kivra-pauoli deleted the feature/erl_files_strict_ruleset branch January 18, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a simple way to run all checks (even optional ones)
3 participants