Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sander's information to the DESCRIPTION #15

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

PietrH
Copy link
Member

@PietrH PietrH commented Nov 14, 2023

I've added @SanderDevisscher as a package author, for his contributions in the design and review of the package so far.

@PietrH PietrH added the documentation Improvements or additions to documentation label Nov 14, 2023
@PietrH PietrH self-assigned this Nov 14, 2023
@PietrH PietrH linked an issue Nov 14, 2023 that may be closed by this pull request
@PietrH
Copy link
Member Author

PietrH commented Nov 14, 2023

Tiny change, just an update to DESCRIPTION. Feel free to merge immediately after review, or to commit changes directly to this branch.

@PietrH PietrH marked this pull request as draft November 14, 2023 09:40
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56a0bb0) 0.00% compared to head (2439b17) 0.00%.

❗ Current head 2439b17 differs from pull request most recent head 9badce7. Consider uploading reports for the commit 9badce7 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #15   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines         47      47           
=====================================
  Misses        47      47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PietrH PietrH marked this pull request as ready for review November 14, 2023 09:52
@PietrH
Copy link
Member Author

PietrH commented Nov 14, 2023

Had a little oopsie, it's fixed now. Turns out the authors field in the DESCRIPTION is executable R code, who knew!

Copy link
Collaborator

@SanderDevisscher SanderDevisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@SanderDevisscher SanderDevisscher merged commit 7509a3a into main Nov 14, 2023
6 checks passed
@SanderDevisscher SanderDevisscher deleted the 14-update-contributors branch November 14, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update contributors
2 participants