-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use changer::changer
to rename package
#22
Conversation
Sander, here is what I think you need to test:
Also: How are we going to handle references to vespawatch going forward, ie in the function documentation and examples. In default values etc. I say we keep them in for now, but it might be a pain removing them later. It's a balance of user friendliness towards ourselves as users, and possible other users that don't know about vespawatch in the future. We might want to avoid setting default values to vespawatch defaults, but it would be handy for us... We could also handle this with System ENV parameters, but I always find that less user friendly when I'm using a new package since this is stuff I can't really see in my IDE. What do you think? |
@PietrH I can plan to test this by this wednesday (29/11) ok? |
Alright, It's better not to merge anything to main in the meantime. I want any merge conflicts to occur with these changes already present in the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
─ R CMD check results iassetR 0.0.0.─
Duration: 17.7s
0 errors ✔ | 0 warnings ✔ | 0 notes ✔
R CMD check succeeded
After cloning & building the package from this branch just changing library(vespawatchr)
to library(iassetR)
in my experimental scripts seems to work like a charm.
Are there any more tests I need to do before merging ?
Nope, all good. I'll merge this one myself! |
Me and @SanderDevisscher have decided to rename the repo, and package from
vespawatchr
toiassetR
because while we currently are writing this in the scope of vespawatch, we want to keep the package general enough to be used by any iAsset user. Any vespawatch specific code should go in vespawatch specific repo's.@SanderDevisscher , I'm setting you as reviewer as soon as this is ready for review. But I would like to merge it into main myself.
From this merge onwards, anyone developing on this package will have to update their local versions to the new repo and project. You can do this in Git CLI or Github Desktop (under repository), but I usually find it easier to just delete my local copy and to clone a new one.