21 convert data from answercode to answer

[PietrH]

Todo

• see if select_inspectors is recoded
  - [ ] Add tests for get_records() especially regarding recoding
• create issue for optionally returning same column names as in iAsset, but set to default FALSE
• Add issue for bad failure state on bad username
• Remove test infrastructure

[SanderDevisscher]

@PietrH can I test this ?

[SanderDevisscher]

PS it works

[PietrH]

Thanks for having a look at it Sander, I'm not ready with this branch yet. I've added a todo list to this PR.

Sorry it's been dragging on. Do you have any experience writing tests with testthat?

[SanderDevisscher]

Sorry no experience with testthat, however I'm willing to learn.

[PietrH]

No worries, we can get together about that at some point. There is some information about it in the R packages book: https://r-pkgs.org/testing-basics.html

[PietrH]

I'll take care of the unit tests for this PR though, don't worry!

[SanderDevisscher]

No worries, we can get together about that at some point. There is some information about it in the R packages book: https://r-pkgs.org/testing-basics.html

thanks

[PietrH]

The failure state when you enter the wrong username isn't very elegant:

get_records(access_token = get_access_token(username = "[email protected]"))

#>Error: access_token is not a string (a length one character vector).

[PietrH]

Select fields are recoded, currently radio and select fields are treated equally.

[PietrH]

I've decided tests are for a seperate PR, in the context of #7 because it'll require a bit more tooling. I'd like to avoid mocking or vcr if at all possible.

[PietrH]

The failure state when you enter the wrong username isn't very elegant:

get_records(access_token = get_access_token(username = "[email protected]"))

#>Error: access_token is not a string (a length one character vector).

#27

[PietrH]

Issue for optionally returning verbatim field names as iAsset: #28

[PietrH]

PS it works

I'm interpreting this as a positive review, and merging to main. If it's broken, please open an issue.