Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc and readme updates #191

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Doc and readme updates #191

merged 8 commits into from
Jun 17, 2024

Conversation

madanucd
Copy link
Contributor

Closes #189 and #190

@madanucd madanucd requested a review from lopierra June 12, 2024 20:33
README.md Outdated Show resolved Hide resolved
@madanucd madanucd requested a review from twhetzel June 13, 2024 13:57
src/docs/about.md Outdated Show resolved Hide resolved
twhetzel
twhetzel previously approved these changes Jun 14, 2024
Copy link

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than one update. See comment inline.

Very nice documentation!!!

@lopierra
Copy link
Member

@madanucd thank you for doing this - it looks great! My only question is whether we can delete the last section of the readme that mentions schematic?

@madanucd
Copy link
Contributor Author

@twhetzel and @lopierra, thank you both for your valuable feedbacks!

@madanucd madanucd merged commit 3be6dbc into main Jun 17, 2024
2 checks passed
@madanucd madanucd deleted the doc_update branch July 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Readme.md
3 participants