fix: update how asl and lsq filters are applied to submissions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
requested changes
Jul 18, 2024
Comment on lines
12
to
17
| {%- if submission.data.youtube.interpretation -%} | ||
| {{ 'asl' if submission.data.youtube.lang === 'en' else 'lsq' }}, | ||
| {{ 'asl' if submission.data.youtube.lang === 'en' and submission.data.youtube.signLanguageUrl }}, | ||
| {%- endif -%} | ||
| {%- if submission.data.youtube.interpretation -%} | ||
| {{ 'lsq' if submission.data.youtube.lang === 'fr' and submission.data.youtube.signLanguageUrl }}, | ||
| {%- endif -%} |
There was a problem hiding this comment.
You probably can consolidate this a little bit as there are two if clauses that do the same thing (check if there's an interpretation).
greatislander
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lintwithout errorsnpm run startand reviewing affected routesnpm run buildwithout errorsDescription
Sign language filters were not working as expected because previously we were expecting to get separate submissions for ASL and LSQ videos. Add additional condition to submissions to check if asl or lsq video is linked.
Steps to test