fix: better checks for random species id

- fixes issue with using old unown ids
- checks for egg

README.md

@@ -19,6 +19,8 @@ This is a decompilation of Pokémon Emerald.
 - [ ] fix the instant text speed setting
 - [ ] update settings page to have more nuzlocke specific settings
 - [ ] update settings page to be scrollable for more settings
+- [ ] don't let rare candies level you up higher than the highest pokemon you have defeated
+- [ ] limit each route to only a few species
 
 It builds the following ROM:
 

src/pokemon.c

@@ -7136,8 +7136,13 @@ u16 RandomPokemonSpecies()
 {
     u16 species = SPECIES_NONE;
     do {
-        species = (Random() % (NUM_SPECIES - 1)) +1;
-    } while (species < SPECIES_BULBASAUR || species > SPECIES_CHIMECHO);
+        species = (Random() % SPECIES_UNOWN_QMARK) +1;
+    } while (
+        species < SPECIES_BULBASAUR 
+            || species > SPECIES_UNOWN_QMARK
+            || species == SPECIES_EGG
+            || (species >= SPECIES_OLD_UNOWN_B && species <= SPECIES_OLD_UNOWN_Z)
+    );
 
     return species;
 }