Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] resolves #58 on newer win32 systems #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BePo65
Copy link

@BePo65 BePo65 commented Nov 14, 2024

On newer win32 systems WMIC is no longer available. The solution recommended by Microsoft is using Powershell.

This pr adds spawning a Powershell script, if WMIC does not exits on a win32 system.

Solves issue #58 on this project and should also solve issue bahmutov/start-server-and-test#384.

@MikeMcC399
Copy link
Contributor

@BePo65

Tip

  • If you write in your original post resolves #58, then the PR automatically gets linked to the issue. See Linking a pull request to an issue using a keyword. You have to write the keyword directly before the issue number, without using the word "issue".

@BePo65 BePo65 changed the title [fix] Issue 58 on newer win32 systems [fix] resolves #58 on newer win32 systems Nov 29, 2024
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, the https://github.com/indexzero/ps-tree/blob/master/README.md#windows section, which refers to WMIC, needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants