Handle corner case in getLatest artifact, which cascades to Poller #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rialPoller In our setup, we've noticed that objectMetadata request after doing a getLatest fails with 404. One possible code path that leads to this is getLatest returning Revisions.base(), which is problematic, since, we consider it to be a valid revision and try to do a metadata fetch. Added a fix to handle it with logging enabled.
|
@ashwanthkumar @manojlds Please take a look at this and share your feedback |
brewkode
commented
Jan 19, 2018
| |} | ||
| """.stripMargin)) | ||
| val resultMap = new GsonBuilder().create.fromJson[AnyRef](result.responseBody(), classOf[Any]) | ||
| assert(result.responseCode() == 200) |
There was a problem hiding this comment.
I can't understand this. I send a INTERNAL_ERROR when handling this particular request from the Plugin side via createResponse(DefaultGoPluginApiResponse.INTERNAL_ERROR, revision.toMap()) . However, the response that's received still has 200 status. I checked other tests which asserts some failures, which returns INTERNAL_ERROR, they also have assertions expecting a 200 response code. Perhaps, is this how, plugin api response is expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our setup, we've noticed that
getObjectMetadatarequest (after doing a getLatest) fails with 404. One possible code path that leads to this isgetLatestreturningRevisions.base(), which is problematic, since, we consider it to be a valid revision and try to do a metadata fetch. Added a fix to handle it with some logging enabled on the plug-in side.