fix: protect against empty key_value pair list

induxx · May 29, 2024 · d66de51 · d66de51
1 parent 83d438d
commit d66de51
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Component/Action/KeyMapperAction.php b/src/Component/Action/KeyMapperAction.php
@@ -33,7 +33,7 @@ public function apply(array $item): array
             return $item;
         }
 
-        $list = $this->getOption('list');
+        $list = array_filter($this->getOption('list'));
         // when dealing with converted data we need the primary keys
         // we just need to replace these keys
         $newList = [];

diff --git a/src/Component/Source/Command/SourceKeyValueCommand.php b/src/Component/Source/Command/SourceKeyValueCommand.php
@@ -17,17 +17,24 @@ class SourceKeyValueCommand implements SourceAwareInterface, ExecuteSourceComman
         'list' => null,
         'key' => null,
         'value' => null,
-        'key_prefix' => ''
+        'key_prefix' => '',
+        'display_empty_values' => true,
     ];
 
     public function execute(): array
     {
-        return KeyValuePairBuilder::build(
+        $list = KeyValuePairBuilder::build(
             $this->getSource()->getCachedReader(),
             $this->getOption('key'),
             $this->getOption('value'),
             $this->getOption('key_prefix'),
         );
+
+        if (true !== $this->getOption('display_empty_values')) {
+            return array_filter($list);
+        }
+
+        return $list;
     }
 
     public function executeWithOptions(array $options)