Skip to content

Commit

Permalink
ISPN-15081 PF5 CSS update
Browse files Browse the repository at this point in the history
  • Loading branch information
dpanshug committed Sep 2, 2023
1 parent 048a14b commit 26d7bef
Show file tree
Hide file tree
Showing 19 changed files with 71 additions and 72 deletions.
4 changes: 2 additions & 2 deletions cypress/e2e/cluster-welcome.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ describe('Welcome page', () => {
//Clicks the Global statistics link and should go to Global statistics page
cy.contains('Global Statistics').click();
cy.contains('Global statistics').should('be.visible');
cy.contains('Cluster-wide statistics ');
cy.contains('Cache Manager lifecycle values ');
cy.contains('Cluster-wide statistics');
cy.contains('Cache Manager lifecycle values');

//Clicks the Data Container link and should go to Data Container page
cy.contains('Data Container').click();
Expand Down
30 changes: 18 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"copy-webpack-plugin": "^11.0.0",
"css-loader": "^5.2.6",
"css-minimizer-webpack-plugin": "^5.0.1",
"cypress": "^12.17.3",
"cypress": "^12.17.4",
"dotenv-webpack": "^8.0.1",
"eslint": "^8.46.0",
"eslint-plugin-i18n-json": "^4.0.0",
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
<goal>npm</goal>
</goals>
<configuration>
<arguments>install cypress@^12.17.3 --verbose</arguments>
<arguments>install cypress@^12.17.4 --verbose</arguments>
</configuration>
</execution>
<execution>
Expand Down Expand Up @@ -146,7 +146,7 @@
<goal>npm</goal>
</goals>
<configuration>
<arguments>install cypress@^12.17.3 --verbose</arguments>
<arguments>install cypress@^12.17.4 --verbose</arguments>
</configuration>
</execution>
<execution>
Expand Down
7 changes: 3 additions & 4 deletions src/app/About/About.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.about-bg {
background-image: url('!!url-loader!@app/assets/images/infinispanbg_1200.png');
background-position: right;
background-size: 23vw 100%;
.pf-v5-c-about-modal-box {
--pf-v5-c-about-modal-box--BackgroundPosition: right;
--pf-v5-c-about-modal-box--BackgroundSize: 23vw 100%;
}
3 changes: 2 additions & 1 deletion src/app/About/About.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
TextListVariants
} from '@patternfly/react-core';
import icon from '!!url-loader!@app/assets/favicons/ms-icon-310x310.png';
import backgroundImage from '!!url-loader!@app/assets/images/infinispanbg_1200.png';
import {
FacebookIcon,
GithubIcon,
Expand Down Expand Up @@ -53,7 +54,7 @@ const About = (props: { isModalOpen: boolean; closeModal: () => void }) => {
brandImageSrc={icon}
brandImageAlt={brandname + ' Logo'}
productName={brandname}
className="about-bg"
backgroundImageSrc={backgroundImage}
>
<Stack>
<StackItem style={{ paddingBottom: global_spacer_lg.value }}>
Expand Down
2 changes: 1 addition & 1 deletion src/app/CacheManagers/CacheTableDisplay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ import {
EmptyStateHeader,
EmptyStateFooter
} from '@patternfly/react-core';
import { Table /* data-codemods */, Thead, Tr, Th, Tbody, Td, IAction, ActionsColumn } from '@patternfly/react-table';
import { Table, Thead, Tr, Th, Tbody, Td, IAction, ActionsColumn } from '@patternfly/react-table';
import { useTranslation } from 'react-i18next';
import { useCaches, useDataContainer } from '@app/services/dataContainerHooks';
import { FilterIcon, SearchIcon } from '@patternfly/react-icons';
Expand Down
2 changes: 1 addition & 1 deletion src/app/Caches/CreateCache.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const CreateCache = () => {
</TextContent>
</ToolbarContent>
{!canCreateCache && (
<ToolbarContent style={{ paddingLeft: 0}}>
<ToolbarContent style={{ paddingLeft: 0 }}>
<Alert
title={t('caches.setup.page-title-description', { brandname: brandname })}
variant={AlertVariant.info}
Expand Down
8 changes: 1 addition & 7 deletions src/app/Caches/DetailCache.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,7 @@ const DetailCache = (props: { cacheName: string }) => {
{encodingMessageDisplay()}
<CacheEntries cacheName={cacheName} />
</Tab>
<Tab
eventKey={13}
data-cy="queriesTab"
title={
<TabTitleText>{t('caches.tabs.query-values')}</TabTitleText>
}
>
<Tab eventKey={13} data-cy="queriesTab" title={<TabTitleText>{t('caches.tabs.query-values')}</TabTitleText>}>
<QueryEntries cacheName={cacheName} indexed={cache?.features.indexed} changeTab={() => setActiveTabKey1(2)} />
</Tab>
</Tabs>
Expand Down
2 changes: 1 addition & 1 deletion src/app/Caches/Entries/CacheEntries.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
EmptyStateFooter
} from '@patternfly/react-core';
import { Select, SelectOption, SelectVariant } from '@patternfly/react-core/deprecated';
import { Table /* data-codemods */, Thead, Tr, Th, Tbody, Td, IAction, ActionsColumn } from '@patternfly/react-table';
import { Table, Thead, Tr, Th, Tbody, Td, IAction, ActionsColumn } from '@patternfly/react-table';
import { FilterIcon, SearchIcon, PlusCircleIcon, HelpIcon } from '@patternfly/react-icons';
import { global_spacer_sm, global_spacer_md } from '@patternfly/react-tokens';
import SyntaxHighlighter from 'react-syntax-highlighter';
Expand Down
2 changes: 1 addition & 1 deletion src/app/Caches/Query/QueryEntries.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const QueryEntries = (props: { cacheName: string; indexed: boolean; changeTab: (
aria-label={'more-info-ickle'}
onClick={(e) => e.preventDefault()}
aria-describedby={'helpickle'}
className="pf-c-form__group-label-help"
className="pf-v5-c-form__group-label-help"
icon={<HelpIcon />}
/>
</Popover>
Expand Down
6 changes: 3 additions & 3 deletions src/app/Common/ConsoleBackground/ConsoleBackground.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.background-img {
background-position: center;
background-size: cover;
.pf-v5-c-background-image {
--pf-v5-c-background-image--BackgroundPosition: center;
--pf-v5-c-background-image--BackgroundSize: cover;
}
3 changes: 2 additions & 1 deletion src/app/Common/ConsoleBackground/ConsoleBackground.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import lg from '!!url-loader!@app/assets/images/infinispanbg_1200.png';
import './ConsoleBackground.css';

const ConsoleBackground = () => {
return <BackgroundImage src={lg} className={'background-img'} />;
return <BackgroundImage src={lg} />;
};

export { ConsoleBackground };
10 changes: 4 additions & 6 deletions src/app/Common/PopoverHelp.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, {ReactNode} from 'react';
import {Button, Flex, FlexItem, Popover, Text, TextContent} from '@patternfly/react-core';
import {HelpIcon} from '@patternfly/react-icons';
import React, { ReactNode } from 'react';
import { Button, Flex, FlexItem, Popover, Text, TextContent } from '@patternfly/react-core';
import { HelpIcon } from '@patternfly/react-icons';

/**
* This component is used to add pop over helps to forms
Expand All @@ -27,9 +27,7 @@ const PopoverHelp = (props: { name: string; label: string; content: string | Rea
<Text>{props.text}</Text>
</TextContent>
</FlexItem>
<FlexItem>
{popOver}
</FlexItem>
<FlexItem>{popOver}</FlexItem>
</Flex>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/app/ConnectedClients/ConnectedClients.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ const ConnectedClients = () => {
<Button
variant="plain"
onClick={(e) => e.preventDefault()}
className="pf-c-form__group-label-help"
className="pf-v5-c-form__group-label-help"
icon={<InfoCircleIcon />}
/>
</Popover>
Expand Down
2 changes: 1 addition & 1 deletion src/app/GlobalStats/ClusterDistributionChart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
ToolbarItemVariant,
Pagination
} from '@patternfly/react-core';
import { Table /* data-codemods */, Thead, Tr, Th, Tbody, Td, TableVariant } from '@patternfly/react-table';
import { Table, Thead, Tr, Th, Tbody, Td, TableVariant } from '@patternfly/react-table';
import {
Chart,
ChartAxis,
Expand Down
8 changes: 4 additions & 4 deletions src/app/ProtoSchema/ProtobufSchemasDisplay.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.app-prefix--m-scroll-content {
--pf-c-table--cell--MinWidth: var(--pf-c-table--m-truncate--cell--MinWidth);
--pf-c-table--cell--MaxWidth: var(--pf-c-table--m-truncate--cell--MaxWidth);
--pf-c-table--cell--Overflow: auto;
--pf-c-table--cell--WhiteSpace: nowrap;
--pf-v5-c-table--cell--MinWidth: var(--pf-v5-c-table--m-truncate--cell--MinWidth);
--pf-v5-c-table--cell--MaxWidth: var(--pf-v5-c-table--m-truncate--cell--MaxWidth);
--pf-v5-c-table--cell--Overflow: auto;
--pf-v5-c-table--cell--WhiteSpace: nowrap;
}
8 changes: 4 additions & 4 deletions src/app/Welcome/Welcome.css
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
}

.version-text {
font-weight: var(--pf-global--FontWeight--bold);
font-weight: var(--pf-v5-global--FontWeight--bold);
margin: 0 0 0.2rem;
}

Expand All @@ -72,11 +72,11 @@
}

.card::before {
content: "";
content: '';
position: absolute;
width: 100%;
height: 3px;
background-color: rgb(60 149 184 );
background-color: rgb(60 149 184);
bottom: 0;
left: 0;
transform: scaleX(0); /* Initially hidden */
Expand All @@ -85,7 +85,7 @@

.card:hover {
background-color: rgb(28, 27, 27);
/* transform: translateY(-5px); */
/* transform: translateY(-5px); */
box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);
cursor: pointer;
}
Expand Down
38 changes: 19 additions & 19 deletions src/app/app.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,43 @@ body,
.caches-table {
}

.pf-c-brand {
.pf-v5-c-brand {
}
.pf-c-nav {
/*--pf-c-nav--m-dark__item--m-current--BackgroundColor: #004B95;*/
.pf-v5-c-nav {
/*--pf-v5-c-nav--m-dark__item--m-current--BackgroundColor: #004B95;*/
}

.status-label {
padding-bottom: var(--pf-global--spacer--sm);
padding-bottom: var(--pf-v5-global--spacer--sm);
}

.status-icon {
padding-left: var(--pf-global--spacer--md);
padding-right: var(--pf-global--spacer--sm);
padding-bottom: var(--pf-global--spacer--sm);
padding-left: var(--pf-v5-global--spacer--md);
padding-right: var(--pf-v5-global--spacer--sm);
padding-bottom: var(--pf-v5-global--spacer--sm);
}

.pf-c-dropdown__menu-item {
.pf-v5-c-dropdown__menu-item {
cursor: pointer;
}

.alert-message.pf-c-alert.pf-m-inline {
--pf-c-alert--BackgroundColor: var(--pf-global--BackgroundColor--100);
--pf-c-alert--BorderTopWidth: 0;
--pf-c-alert--PaddingTop: 0;
.alert-message.pf-v5-c-alert.pf-m-inline {
--pf-v5-c-alert--BackgroundColor: var(--pf-v5-global--BackgroundColor--100);
--pf-v5-c-alert--BorderTopWidth: 0;
--pf-v5-c-alert--PaddingTop: 0;
}

.failed-link.pf-c-button {
--pf-c-button--m-link--Color: var(--pf-global--danger-color--100);
--pf-c-button--m-link--hover--Color: var(--pf-global--danger-color--200);
--pf-c-button--m-link--focus--Color: var(--pf-global--danger-color--200);
--pf-c-button--m-link--active--Color: var(--pf-global--danger-color--200);
.failed-link.pf-v5-c-button {
--pf-v5-c-button--m-link--Color: var(--pf-v5-global--danger-color--100);
--pf-v5-c-button--m-link--hover--Color: var(--pf-v5-global--danger-color--200);
--pf-v5-c-button--m-link--focus--Color: var(--pf-v5-global--danger-color--200);
--pf-v5-c-button--m-link--active--Color: var(--pf-v5-global--danger-color--200);
}

.pf-c-toolbar {
.pf-v5-c-toolbar {
padding-bottom: 0;
}

.pf-c-table__action {
.pf-v5-c-table__action {
text-align: right;
}

0 comments on commit 26d7bef

Please sign in to comment.