[14.0] ISPN-15125 Error page is shown for non-admin user if accesses cache to which has permission #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karesti
changed the title
karesti
changed the title
karesti
force-pushed
the
fix-rbac
branch
10 times, most recently
from
e073cd1 to
c49c6b4
Compare
|
@karesti may I look into the tests? Or the PR is not yet ready? |
|
not yet @andyuk1986 |
karesti
force-pushed
the
fix-rbac
branch
12 times, most recently
from
b3e04bc to
41865a7
Compare
karesti
commented
Oct 9, 2023
| @@ -15,8 +15,6 @@ describe('Cache Detail Overview', () => { | |||
| cy.contains('Entries'); | |||
| cy.contains('Configuration'); | |||
| cy.contains('Metrics (Enabled)'); | |||
|
|
|||
| verifyCacheMetrics(0, 0, 0, 0, 0, 0, 0, 0, 0, 0); | |||
There was a problem hiding this comment.
@andyuk1986 I removed this check because it depends too much in Infinispan and I believe we need a test for only those stats but not mixing checking that we can create stuff and then check metrics. Otherwise tests are too flaky and it's super hard to maintain in the long run.
|
@andyuk1986 this should be ready for review from your side (to close the issue) |
…o which has permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-15125