Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-14054 Add protobuf schema using Upload on the console #410

Closed
wants to merge 0 commits into from

Conversation

himanshu608
Copy link
Collaborator

@himanshu608 himanshu608 commented Oct 9, 2023

Closes: #400

Description

This is a feature to upload protobuf schema file while creating schema on the console.

UI change:
Screenshot 2023-10-09 220504

How Has This Been Tested?

Tested manually on local environment.

Test Impact

Tests are done manually on local development environment.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work.
  • Commit message includes a reference to the corresponding JIRA issue (eg. commit message: "ISPN-1234 JIRA TITLE...").
  • Commits have been squashed and self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed).
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.

@himanshu608 himanshu608 self-assigned this Oct 9, 2023
@himanshu608 himanshu608 requested a review from dpanshug October 9, 2023 16:51
@karesti
Copy link
Collaborator

karesti commented Oct 13, 2023

@himanshu608 thanks for the contribution! please open a PR only with the changes related to the issue :)

@karesti
Copy link
Collaborator

karesti commented Oct 13, 2023

@himanshu608 please rebase the changes in main branch that fix the tests failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add protobuf schema using Upload on the console
2 participants