-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize Transformation API #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 99.74% 99.77% +0.03%
==========================================
Files 36 35 -1
Lines 6703 6712 +9
==========================================
+ Hits 6686 6697 +11
+ Misses 17 15 -2 ☔ View full report in Codecov by Sentry. |
pulsipher
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
breaking
This will introduce breaking changes to the API
transformations
Something to do with model transformations
labels
Jul 3, 2024
For now, I am going to turn off the |
This was referenced Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
This will introduce breaking changes to the API
documentation
Improvements or additions to documentation
enhancement
New feature or request
transformations
Something to do with model transformations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the optimizer model abstraction which was limited to JuMP Models with a new abstraction based on what is called transformation backends. This introduces
AbstractTransformationBackend
to enable the use of arbitrary backends for solving InfiniteModels. For backends that use JuMP, this also addsJuMPBackend <: AbstractTransformationBackend
which provides a similar API to the old optimizer model interface except it is more polished and doesn't rely on hacky "optimizer model keys".TranscriptionOpt now only exports
TranscriptionBackend
which is based onJuMPBackend
. All the former TranscriptionOpt specific query functions have been dropped from main API in favor of the general purpose ones (e.g.,transformation_variable
).This also adds a few missing JuMP methods which include:
set_attribute
get_attribute
unsafe_backend
compute_conflict!
copy_conflict
set_string_names_on_creation
print_active_bridges
print_bridge_graph
It also cleans up the documentation and bit and uses the latest Documenter version.
Partly addresses #105 and #327. What remains for #105, is to decouple the transcription specific approaches from InfiniteOpt. This will require the following: