Fix: Add Android 13 notification permission support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/infinum/android-sentinel into fix/crash-notifications-not-showing-on-android-13
AsimRibo
approved these changes
Mar 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
Fix for #45
📝 Changes
Update readme to let users know that from Android 13 they need to turn on notifications on app level if they want to see them.
Add notifications permission to manifest.
Add logic to check if notifications are enabled before creating notifications.
Add check for notifications permission in settings. (currently only for crash monitor & certificate base on info from NotificationFactory, if we need to add somewhere else, just ping me).
Also, a permission check is only executed if at least one option is enabled. This is not the greatest solution, but it should be fine.
🚫 Breaking
Shouldn't be
🛠️ How to test
Try sample app on Android 13+ device.
⏱️ Next steps
Taking a look at other issues