-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sort to shared prefs tool #72
Conversation
Looking at the video, it seems as if the sorting is implemented only within a certain category (shared prefs file), and there is no way to sort categories. Since my initial motivation behind the request was to make the finding of your own custom prefs easier by making the sort of categories themselves more consistent/predictable or customizable, I'm wondering whether we could achieve that too (or instead). Additionally, does this persist - and if not, could it? Same reasoning. |
OK, I see your point about sorting categories. I see value in the current solution and we will include it in upcoming release. We will look into additional options for shared prefs tools. |
Just questions about your use case @JonatanPlesko |
@KCeh I'm usually looking for a specific preference file and/or a specific key. Minimizing other preference files would help, and so would search or filtering. I initially suggested sorting to have a consistent logic at least, as I noticed the order would randomly change, making it even more difficult to find what you're looking for as it is always in a different place. |
I further improved options, now all preferences files should be sorted (always). Meaning consistency in list. Screen_recording_20240709_181422.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Nothing to add, for first iteration looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These additional changes are great 👏 👏 👏 the consistent sort + the ability to collapse them is already a big improvement and will definitely make it much easier to find specific preferences. Thank you for the effort 🙌
sentinel/src/main/kotlin/com/infinum/sentinel/ui/main/preferences/PreferencesFragment.kt
Outdated
Show resolved
Hide resolved
sentinel/src/main/kotlin/com/infinum/sentinel/ui/main/preferences/PreferencesFragment.kt
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
📷 Screenshots
Check out video in comments down below
📄 Context
Requested in #44.
I added a sort by key to shared preferences tools. Worth keeping in mind that tool works in a way that separates each prefs file in UI (for example encrypted shared prefs are not mixed with normal shared prefs - check out video).
📝 Changes
I added:
🛠️ How to test
Run sample app or any other app that uses Sentinel. Worth noting that you might need to set some shared prefs.