Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have integrated Binary compatibility validator into Sentinel 🎉
This tool will be used to pay closer attention to public API changes (since Sentinel is library!)
Changes
Type
Additional information
Description
With this PR we will have the option to use binary compatibility validator for public API changes.
The tool is configured only to generate API for libs (not sample app!). Gradle task for API dump is
apiDump
We can use Gradle task
apiCheck
to check changes in public API.Why is this important?
Because Sentinel is library. And if we changed API that consumer use then consumers will encounter breaking changes.
This is also helpful to know when to bump major version in major.minor.patch versioning system.
Checklist
Additional notes