WIP: allow customizing cookie consent, help needed #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibotty
force-pushed
the
customized-choice
branch
from
65a6416 to
8c2384a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to use a custom form that says which cookies can be set (analytics, advertisement, etc.).
I tried to keep it backwards-compatible and think I succeeded.
Do you like the direction this is going? If so, I can add some more polish.
To add it to
cookies_eu, at least the following things should be fixed.The last part I cannot fix by myself. I am no designer at all. I am using it with proprietary CSS by another person I cannot share and which does not fit into
cookies_euanyway.I added a few more things that I can pull out and add to other pull requests if desired (see the commits).