Simplify adding requirements #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truba
approved these changes
Dec 12, 2024
| This method is designed for Objective-C compatibility and uses runtime type checking (`isKindOfClass:`) to validate the value. | ||
| */ | ||
| @objc(addRequirementWithKey:ofType:requirementCheck:) | ||
| public func addRequirementWithKey(key: String, ofType type: AnyClass, requirementCheck: @escaping (Any) -> Bool) { |
There was a problem hiding this comment.
Can we also add unavailable for swift flag, the last time I did it, i think it was adding __ to the function name, but there might be be a better option now.
jabou
reviewed
Dec 16, 2024
| @objc(addRequirementWithKey:ofType:requirementCheck:) | ||
| public func addRequirementWithKey(key: String, ofType type: AnyClass, requirementCheck: @escaping (Any) -> Bool) { | ||
| userRequirements.updateValue({ value in | ||
| guard let value = value as? NSObject, value.isKind(of: type) else { return false } |
There was a problem hiding this comment.
Instead of returning false if the type does not match, maybe we could throw an error? That way, the user would know something went wrong instead of just getting a false negative response. What do you think about that approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a generic method that accepts the expected type explicitly and handles the type casting internally.