feat(conn-pkg): use types for compression in conn pkg (#4197)

* feat: use types for compression in conn pkg * fix: use ref for compression enum * feat: update compression instances * fix: version * feat: use serde lowercase * fix: clippy * revert: fluvio crate updates
infinyon · Sep 27, 2024 · f08c65e · f08c65e
1 parent 8b3da39
commit f08c65e
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/fluvio-connector-common/src/producer.rs b/crates/fluvio-connector-common/src/producer.rs
@@ -18,8 +18,8 @@ pub async fn producer_from_config(config: &ConnectorConfig) -> Result<(Fluvio, T
         };
 
         // Compression
-        if let Some(compression) = producer_params.compression {
-            config_builder = config_builder.compression(compression)
+        if let Some(compression) = &producer_params.compression {
+            config_builder = config_builder.compression(compression.clone())
         };
 
         // Batch size

diff --git a/crates/fluvio-connector-package/Cargo.toml b/crates/fluvio-connector-package/Cargo.toml
@@ -28,7 +28,6 @@ fluvio-controlplane-metadata = { path = "../fluvio-controlplane-metadata/", defa
 fluvio-smartengine = { path = "../fluvio-smartengine", default-features = false, features = [
     "transformation",
 ] }
-fluvio-compression = { path = "../fluvio-compression" }
 fluvio-types = { path = "../fluvio-types" }
 bytesize-serde = "0.2.1"
 

diff --git a/crates/fluvio-connector-package/src/config/mod.rs b/crates/fluvio-connector-package/src/config/mod.rs
@@ -15,8 +15,8 @@ pub use bytesize::ByteSize;
 
 pub use fluvio_controlplane_metadata::topic::config as topic_config;
 pub use fluvio_smartengine::transformation::TransformationStep;
-pub use fluvio_compression::Compression;
 pub use fluvio_types::PartitionId;
+pub use fluvio_types::compression::Compression;
 
 use crate::metadata::Direction;
 

diff --git a/crates/fluvio-types/Cargo.toml b/crates/fluvio-types/Cargo.toml
@@ -14,7 +14,7 @@ events = ["event-listener"]
 event-listener = { workspace = true,  optional = true }
 thiserror = { workspace = true }
 tracing = { workspace = true }
-serde = { workspace = true }
+serde = { workspace = true, features = ["derive"], default-features = false }
 toml = { workspace = true, features = ["display", "preserve_order", "parse"] }
 
 [dev-dependencies]

diff --git a/crates/fluvio-types/src/compression.rs b/crates/fluvio-types/src/compression.rs
@@ -1,4 +1,7 @@
-#[derive(Clone, Debug, Eq, PartialEq)]
+use serde::{Serialize, Deserialize};
+
+#[derive(Clone, Debug, Deserialize, Eq, Serialize, PartialEq)]
+#[serde(rename_all = "lowercase")]
 pub enum Compression {
     None,
     Gzip,