Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release CI #12

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Refactor release CI #12

merged 3 commits into from
Dec 2, 2024

Conversation

syndr
Copy link
Collaborator

@syndr syndr commented Dec 2, 2024

Image tags will be generated based upon the event that triggered the workflow:

  • push event:
    • main branch: latest
    • devel branch: devel
    • all other branches: <branch name>-latest
  • pull_request event: DEV-PR-<pull_request_number>
    • Branches must be added to the on.pull_request.branches array above to trigger
  • release event: <tag_name>
  • schedule event: nightly
    • This will be the same configuration as the latest tag, but may contain updated packages, etc. from upstream
  • all other events: <first 7 chars of commit sha>

Run podman test as part of same workflow as release (fail faster)

Image tags will be generated based upon the event that triggered the workflow:
  - push event:
    - main branch: latest
    - devel branch: devel
    - all other branches: <branch name>-latest
      Branches must be added to the on.push.branches array above to trigger
  - pull_request event: DEV-PR-<pull_request_number>
    Branches must be added to the on.pull_request.branches array above to trigger
  - release event: <tag_name>
  - schedule event: nightly
    This will be the same configuration as the 'latest' tag, but may contain updated packages, etc. from upstream
  - all other events: <first 7 chars of commit sha>

Run podman test as part of same workflow as release (fail faster)
@syndr syndr self-assigned this Dec 2, 2024
syndr added 2 commits December 2, 2024 01:33
No need to run on chages of only markdown files
@emoruzzi
Copy link

emoruzzi commented Dec 2, 2024

Do we need to schedule nightly, or is that something we can do weekly?

@emoruzzi
Copy link

emoruzzi commented Dec 2, 2024

We may want to consider using something like if: github.event.review.state == 'approved' since this is public too

@syndr
Copy link
Collaborator Author

syndr commented Dec 2, 2024

Do we need to schedule nightly, or is that something we can do weekly?

Weekly would probably be plenty -- I can do that.

@emoruzzi
Copy link

emoruzzi commented Dec 2, 2024

We may want to consider using something like if: github.event.review.state == 'approved' since this is public too

Managed this via action settings

@emoruzzi emoruzzi marked this pull request as ready for review December 2, 2024 17:32
@emoruzzi emoruzzi merged commit 104ed5f into build-runner Dec 2, 2024
0 of 2 checks passed
@emoruzzi emoruzzi deleted the feat/refactor-ci branch December 2, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants