feat: delete old Catalogs on persist #25568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the code so that we only keep the 10 most recent Catalogs. When a new one is persisted we delete any old ones that exist. If the deletion would fail we don't panic and let a future persist cleanup the catalogs rather than failing the persist itself. This commit also adds a test to make sure that only the catalogs we expect to are deleted on persist.
praveen-influx
approved these changes
Nov 19, 2024
hiltontj
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the code so that we only keep the 10 most recent Catalogs. When a new one is persisted we delete any old ones that exist. If the deletion would fail we don't panic and let a future persist cleanup the catalogs rather than failing the persist itself. This commit also adds a test to make sure that only the catalogs we expect to are deleted on persist.