feat: tidy up sys event store #25610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-influx
force-pushed
the
praveen/sys-events-tidy-up
branch
2 times, most recently
from
036e92d to
6998d64
Compare
praveen-influx
force-pushed
the
praveen/sys-events-tidy-up
branch
2 times, most recently
from
76d2252 to
935ef94
Compare
- This commit allows `RecordBatch` to be created directly from event store. It means we can avoid cloning events and avoids creating intermediate vec. To achieve that, there's a new method `as_record_batch` that's been added with a trait bound `ToRecordBatch` that events are expected to implement. - Minor tidy ups (renaming methods) and added test closes: #25609
praveen-influx
force-pushed
the
praveen/sys-events-tidy-up
branch
from
935ef94 to
87f14ed
Compare
hiltontj
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RecordBatchto be created directly from sys event store. It means we can avoid cloning events and avoids creating intermediate vec. To achieve that, there's a new methodto_record_batchthat's been added with a trait boundToRecordBatchthat events are expected to implement.closes: #25609