Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync latest IOx #38

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: sync latest IOx #38

merged 1 commit into from
Dec 4, 2024

Conversation

hiltontj
Copy link
Collaborator

@hiltontj hiltontj commented Dec 4, 2024

revision range: ba3189c47..064fdcbe6

See the PR in influxdb that uses this change: influxdata/influxdb#25617

@hiltontj hiltontj requested review from praveen-influx and a team December 4, 2024 16:23
@hiltontj hiltontj self-assigned this Dec 4, 2024
@hiltontj hiltontj marked this pull request as ready for review December 4, 2024 16:35
revision range: ba3189c47..064fdcbe6

Co-authored-by: Adam Curtis <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Carol (Nichols || Goulding) <[email protected]>
Co-authored-by: Chunchun Ye <[email protected]>
Co-authored-by: Dom Dwyer <[email protected]>
Co-authored-by: Fraser Savage <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Joe-Blount <[email protected]>
Co-authored-by: June <[email protected]>
Co-authored-by: Marco Neumann <[email protected]>
Co-authored-by: Martin Hilton <[email protected]>
Co-authored-by: Timothy Maloney <[email protected]>
Co-authored-by: Trevor Hilton <[email protected]>
Co-authored-by: epgif <[email protected]>
@hiltontj hiltontj force-pushed the trevor/core-sync-064fdcbe6 branch from 3ccd28c to 6f3fcaf Compare December 4, 2024 16:39
@praveen-influx
Copy link
Contributor

praveen-influx commented Dec 4, 2024

is this generated using the sync script?

@hiltontj
Copy link
Collaborator Author

hiltontj commented Dec 4, 2024

is this generated using the sync script?

Unfortunately, not entirely. There is no readarray command on MacOS, so I can't use the script all the way. It does speed the process up a bit, but I need to still manually do some things.

@hiltontj
Copy link
Collaborator Author

hiltontj commented Dec 4, 2024

There is no readarray command on MacOS [...]

That actually seems to not be the problem. My installed bash has readarray, but fish shell seems to be thwarting it. I will look into that...

Copy link
Member

@pauldix pauldix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure you want to retry with the script, but if not, approving so you can move forward 😄

@hiltontj
Copy link
Collaborator Author

hiltontj commented Dec 4, 2024

Thanks - I have done it manually enough times that it wasn't a big deal for me but I will try harder to use the script next time 😆

@hiltontj hiltontj merged commit 7eefba9 into main Dec 4, 2024
@hiltontj hiltontj deleted the trevor/core-sync-064fdcbe6 branch December 4, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants