feat: add timestamp-query feature to allow timestamp offset query
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
requested changes
Oct 21, 2024
|
I have change the code for a better API with |
|
Sorry for the long wait. I have added test to query timestamp offset. @crepererum |
crepererum
reviewed
Nov 14, 2024
crepererum
reviewed
Nov 14, 2024
|
Pls have a look. @crepererum |
crepererum
approved these changes
Nov 22, 2024
|
Ah, last minute issue: could you squash all commits into a single one and name it:
|
|
done |
|
Sorry for the CI failure, this will get fixed by #251 (seems to be bad timing). |
|
@crepererum seems good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allow timestamp query for partition offset. As stated in the doc comment of
OffsetAt, timestamp-based query is inconsistent, but I think it better to let the users make their own choice instead of total removal of this sometimes useful feature. I add a feature gate to disable timestamp-based query for offset by default, only those actively looking for timestamp-based query would enable this feature.