chore: Remove MQTT Page and Native Subscriptions Components from C2 UI #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegesse-w
changed the title
wdoconnell
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Hi @blegesse-w Thanks for doing this - I had two comments:
- I'll revalidate when I can spin up remocal, but I believe we need to still expose the UI elements that reference the telegraf MQTT plugin (not part of the C2 native subscriptions feature).
- Before closing the issue (i.e. after this PR is merged) there is still a little more cleanup to do (removing the feature flag in ConfigCat and IDPE).
blegesse-w
force-pushed
the
chore/remove_mqtt_components
branch
2 times, most recently
from
113bff0
to
8a1822e
Compare
blegesse-w
commented
Nov 1, 2024
| )} | ||
| /> | ||
| )} | ||
| {CLOUD && ( |
There was a problem hiding this comment.
not sure why this wasn't put behind the subscriptionsUI ff. 🤔
wdoconnell
previously approved these changes
Nov 13, 2024
| @@ -77,3 +77,4 @@ | |||
| ## Value supported is int, float, unit | |||
| # [[inputs.mqtt_consumer.topic.types]] | |||
| # key = type | |||
|
|
|||
There was a problem hiding this comment.
I would git checkout main -- [this file] to revert any change -- it's just whitespace but we don't want history that suggests a change was made here since we are not altering availability of the telegraf plugin.
| @@ -197,7 +197,7 @@ sensors,site=CLE,version=v1,device_name=device5 temp=390,rpm=45.0,ph=1.45 | |||
| - when [[inputs.internal]] is set: | |||
| - payload_size (int): get the cumulative size in bytes that have been received from incoming messages | |||
| - messages_received (int): count of the number of messages that have been received from mqtt | |||
|
|
|||
There was a problem hiding this comment.
Same comment here re: space in this file we aren't changing.
|
Rerunning monitor-ci tests: they failed because of a remocal deployment failure that is likely unrelated to this PR. |
blegesse-w
force-pushed
the
chore/remove_mqtt_components
branch
3 times, most recently
from
84f60a3
to
05b6459
Compare
blegesse-w
force-pushed
the
chore/remove_mqtt_components
branch
from
05b6459
to
1bc235a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes granite#3226
This PR addresses part of issue 3226 by removing the Native Subscriptions/MQTT page and any components exclusively used by it from the codebase. The associated subscriptions tests were already removed in a previous PR. With this change, we're continuing the cleanup of deprecated MQTT-related features as customers no longer use them
Checklist
Authors and Reviewer(s), please verify the following: