added BackupRetentionPeriod config

[ssuman2-infoblox]

V1 Story: B-98504

Added BackupRetentionPolicy flag to configure it for prod and non-prod envs

[bjeevan-ib]

should we account aurora workflow?

[abalaven]

What are we specifying in the backupRetentionPeriod field?

[ssuman2-infoblox]

should we account aurora workflow?

@bjeevan-ib I've added this config for DBCluster as well. Usually, backup retention period can't be set to 0 for aurora but the value can be managed with DBCluster.

What are we specifying in the backupRetentionPeriod field?

@abalaven this field is used to set the number of days for which automated backups are retained. More about this is here: https://doc.crds.dev/github.com/crossplane/provider-aws/rds.aws.crossplane.io/DBInstance/[email protected]#spec-forProvider-backupRetentionPeriod

[abalaven]

IIUC, the default value for backupRetentionPeriod is set to 0 in the values file, which I believe will be added to the configMap. Is there any provision to set the value independent of the CM? The CM only holds default values if I'm not wrong.

[drewwells]

Use a string and pass it through time.ParseDuration(). time.Duration is represented as int64 in nanoseconds, so this will be ridiculous to configure if somebody wants 365 days
backup: 3.1536e16

[pjferrell]

Metav1.Duration is the standard kubernetes serialization of a golang duration. It should allow controller to unmarshal to the time.Duration https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/duration.go

…

On Mon, Sep 11, 2023, 14:02 Drew Wells ***@***.***> wrote: ***@***.**** requested changes on this pull request. Use a string and pass it through time.ParseDuration(). time.Duration is represented as int64 in nanoseconds, so this will be ridiculous to configure if somebody wants 365 days backup: 3.1536e16 — Reply to this email directly, view it on GitHub <#173 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7SRDOK7OPOBGU7JXHRI23XZ5N3FANCNFSM6AAAAAA4OL7QEI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ssuman2-infoblox]

Use a string and pass it through time.ParseDuration(). time.Duration is represented as int64 in nanoseconds, so this will be ridiculous to configure if somebody wants 365 days backup: 3.1536e16

@drewwells @pjferrell, as per docs it only accepts value from 0-35 (0 means disabled) and it denotes number of days. We can't set it beyond 35.

[ssuman2-infoblox]

IIUC, the default value for backupRetentionPeriod is set to 0 in the values file, which I believe will be added to the configMap. Is there any provision to set the value independent of the CM? The CM only holds default values if I'm not wrong.

@abalaven I initially tried using arguments to db-controller to pass such values but it required multiple function signature changes. Also we don't want it to be set at dbclaim level but db-controller so CM seemed a good option as it's already configured to take db-controller config as input.

Added something similar here: #172