DO NOT APPROVE/MERGE - adding dsnexec as a sidecar [OLD] #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abalaven
reviewed
Sep 21, 2023
cmd/manager/main.go
Outdated
Comment on lines
176
to
179
| webHookServer := mgr.GetWebhookServer() | ||
|
|
||
| webHookServer.Port = 7443 | ||
| webHookServer.CertDir = "./certs/" |
There was a problem hiding this comment.
We are initializing the webhook only if either dbproxy or dsnexec is enabled. We don't need the webhook if neither of them are enabled.
There was a problem hiding this comment.
@abalaven - tx, done
abodhekar
force-pushed
the
feature/add-dsnexec-as-a-sidecar
branch
from
07a78f0 to
c0331bb
Compare
abodhekar
changed the title
abodhekar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add dsnexec as a side-car container.
Whenever db-controller would see following two annotations, it would add the sidecar.
remote-db-dsn-secret - In case of RDS, it would be the secret created by DBClaim. This would be mounted as a volume inside the sidecar. the dsn.txt file can be watched for changes (by configuring such through dsnexec config.yaml).
dsnexec-config-secret - This would be a secret which needs to be created by the apps. This should contain data as
This would be mounted as a volume inside the sidecar. The path to config.yaml file is given to the dsnexec entrypoint.