fixing fsnotify behaviour upon change in files which are volume mounted through secrets (New) #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue - https://infoblox.atlassian.net/browse/ATLAS-16938
Cause of the issue -
when a watch is added on a file, which is volume mounted through secrets, fsnotify emits 1 or more events including REMOVE.
This is due to the underlying behaviour of updation of files upon updation of corresponding secret keys of kubernetes.
the REMOVE event emitted by fsnotify , internally removes a watch on the path/file.
We were additionally removing the watcher, which resulted into "removal of non-existent watcher"
Solution -
Avoided FATAL, when fsnotify errors "removal of non-existent watcher"
Also sometimes there are more than one event emitted on secret/file change such as REMOVE and CHMOD etc. Upon which pgbouncer could have reloaded similar configuration a few times. Avoided this by caching latest db creds and verify the newer ones are not same as latest used ones.
Due to REMOVE event of file upon change in secret, precautionary checked whether the files are available on the paths before adding a new watcher