modified unit test to reflect RDS scenario #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjeevan-ib
changed the title
abalaven
reviewed
Oct 2, 2023
pkg/pgctl/pgctl.go
Outdated
Comment on lines
266
to
270
| if len(role) > 2 { | ||
| if string(role[len(role)-2]) == "_" { | ||
| role = role[:len(role)-2] | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you add a comment on what this does for the sake of clarity?
bjeevan-ib
force-pushed
the
augment_unit_test
branch
4 times, most recently
from
b11b862 to
ddd716a
Compare
bjeevan-ib
force-pushed
the
augment_unit_test
branch
from
ddd716a to
e25345e
Compare
abalaven
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to application logic.