-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add operational status to migrated rds nstances #192
Feature/add operational status to migrated rds nstances #192
Conversation
02d44ef
to
94ed0a4
Compare
…er related resources allowing post actions after migration only for once binding tagging component with DBClaim reconcile cycle changes to handle tagging and deletion for DBCluster, DBCluserParamGroup etc updating comments. Also, deleted resources if tags updation could not be verified within defined time refactoring code refactored
94ed0a4
to
28df458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to revisit the deleteworkflow - maybe we can treat it as a separate unit of work
@@ -80,6 +80,9 @@ const ( | |||
// DebugLevel is used to set V level to 1 as suggested by official docs | |||
// https://github.com/kubernetes-sigs/controller-runtime/blob/main/TMP-LOGGING.md | |||
DebugLevel = 1 | |||
|
|||
operationalStatusTagKey string = "OPERATIONAL_STATUS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key and value need to match the style of tags we are using right now. if I remember right, devops goes with initcap with kabab case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjeevan-ib - done
@@ -220,6 +231,8 @@ func (r *DatabaseClaimReconciler) getMode(dbClaim *persistancev1.DatabaseClaim) | |||
return M_UpgradeDBInProgress | |||
|
|||
} | |||
} else if dbClaim.Status.OldDB.DbState == persistancev1.PostMigrationInProgress { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this not be made a simple check right in the top - by checking for oldDB being not null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjeevan-ib - done
This is to -